search

trinodb / charts

Apache License 2.0
151 stars 173 forks source link

Fix JMX Exporter container port spec #222

Closed sdaberdaku closed 2 months ago

sdaberdaku commented 2 months ago

I moved the JMX Exporter container port to correct container (previously located on the coordinator container), with a minor.

Also, the property .Values.jmx.exporter.configProperties was declared as a list which was incorrect. I converted it to a templated multiline string.

I also updated the minimal JMX configuration example in the default value of .Values.jmx.exporter.configProperties.

Fixes #221

sdaberdaku commented 2 months ago

Dear @nineinchnick,

Thank you for your review. I implemented the changes and did a rebase.

Please let me know if you have any more comments.

Best,

S.