search

trinodb / charts

Apache License 2.0
151 stars 173 forks source link

Add option to enable JMX exporter on workers #227

Closed sdaberdaku closed 1 month ago

sdaberdaku commented 1 month ago

Fixes #224

sdaberdaku commented 1 month ago

Hi @nineinchnick! I was wondering if you could review this PR, whenever you get the chance!

Thanks!

Sebastian

sdaberdaku commented 1 month ago

Hello @nineinchnick,

I implemented the suggested changes.

I added a headless Service for worker Pods which serves as a target for a dedicated ServiceMonitor. I added coordinator and worker blocks inside jmx and serviceMonitor so that users can override the respective configurations of the components. I extended the existing JMX test to cover the changes that I made. Finally, I made a slight change to test.sh and configured Prometheus to scrape only ServiceMonitors with a specific label (which is also set in test-values.yaml: serviceMonitor.labels.prometheus=default) - less entropy.

Let me know if you have any more comments!