search

trinodb / charts

Apache License 2.0
151 stars 173 forks source link

add_separate_group.db_secret #230

Closed vladimir4862 closed 1 month ago

vladimir4862 commented 1 month ago

Hello! I'm not very experienced with Trino configuration, but I do have a bit more experience with Helm charts. The main question in this PR is determining the correct place to change the file.password-file and file.group-file configurations.

I placed them in a separate folder to keep automatic updates when k8s secrets are updated. This approach contrasts with using subPath, which does not support automatic file updates within pod volumes.

I was inspired by the issue So maybe @robertpikmets also whant to look at this.

cla-bot[bot] commented 1 month ago

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: valdimir. This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email email@example.com
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails
vladimir4862 commented 1 month ago

@cla-bot check

cla-bot[bot] commented 1 month ago

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: valdimir. This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email email@example.com
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails
cla-bot[bot] commented 1 month ago

The cla-bot has been summoned, and re-checked this pull request!