search

trinodb / charts

Apache License 2.0
151 stars 173 forks source link

add_separate_group.db_secret #231

Closed vladimir4862 closed 4 days ago

vladimir4862 commented 1 month ago

Hello! I'm not very experienced with Trino configuration, but I do have a bit more experience with Helm charts. The main question in this PR is determining the correct place to change the file.password-file and file.group-file configurations.

I placed them in a separate folder to keep automatic updates when k8s secrets are updated. This approach contrasts with using subPath, which does not support automatic file updates within pod volumes.

vladimir4862 commented 1 month ago

I was inspired by the https://github.com/trinodb/charts/issues/188 So maybe @robertpikmets also whant to look at this.

vladimir4862 commented 1 month ago

I'll check and make test during this week

vladimir4862 commented 1 month ago

I changed group to goups almost in all cases. to keep the same world in template and values.

I still not sure what changes, and test cases you are talking about testCase "complete_values" checked this changes. because this value has groups. https://github.com/trinodb/charts/blob/main/test-values.yaml#L37

Could you provide more information about it? I really want to help here, but not sure how.

vladimir4862 commented 1 month ago

Terrably sorry for this little typos. 😸 just fixed all. about naming, As I said i'm not very familiar with trinodb itself, just whant to add a some feature in helm chart which will help me to deploy it.

nineinchnick commented 1 month ago

As the old joke says, the two hardest problems in IT are:

  1. naming
  2. cache invalidation
  3. off-by-one errors

Let's figure out good names here together.

nineinchnick commented 4 days ago

@cla-bot check

cla-bot[bot] commented 4 days ago

The cla-bot has been summoned, and re-checked this pull request!