search

trinodb / charts

Apache License 2.0
151 stars 173 forks source link

Remove `.Values.server.config.http` section from chart #233

Closed romsharon98 closed 1 month ago

romsharon98 commented 1 month ago

closes: https://github.com/trinodb/charts/issues/229

cla-bot[bot] commented 1 month ago

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

cla-bot[bot] commented 1 month ago

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

romsharon98 commented 1 month ago

verified cla, can you run the test again please? @nineinchnick

nineinchnick commented 1 month ago

@cla-bot check

cla-bot[bot] commented 1 month ago

The cla-bot has been summoned, and re-checked this pull request!

nineinchnick commented 1 month ago

Please squash both commits and write a good commit message, like "Remove unused property"

romsharon98 commented 1 month ago

Please squash both commits and write a good commit message, like "Remove unused property"

done.