search

trinodb / charts

Apache License 2.0
151 stars 173 forks source link

Allow setting more deployment options #236

Closed amarthey closed 1 month ago

amarthey commented 1 month ago

Adding deployment spec values for coordinator deployment and worker deployment:

 - progressDeadlineSeconds
 - revisionHistoryLimit
 - strategy

This is needed for us in case of an update of Trino Cluster that requires the deployment to bring pods up and down.

cla-bot[bot] commented 1 month ago

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

amarthey commented 1 month ago

I sent the signed CLA on 9/26 😃

nineinchnick commented 1 month ago

The CLAs are processed every two weeks or so. If you've already sent it, don't worry about it, I'll keep an eye on them

amarthey commented 1 month ago

ons on how to do that.

This is my first PR and I did not know about that. Let me address your comments

amarthey commented 1 month ago

Sounds good. I will squash.