search

trinodb / charts

Apache License 2.0
151 stars 173 forks source link

Allow autoscaling by memory utilization #239

Closed dantonbertuol closed 1 month ago

dantonbertuol commented 1 month ago

Hello!

This PR aims to enable the possibility of using memory resource in the HPA. I noticed that there is an open PR (https://github.com/trinodb/charts/pull/219) regarding this, but it has been inactive for a month, and this is a feature I really need.

A new variable has been created in the values (targetMemoryUtilizationPercentage), with a default value of 80. In the HPA manifest, I added a conditional check to see if a value is set for this variable, allowing the assignment of an empty value ("") to one of them to not use the metric. I also included this condition for targetCPUUtilizationPercentage (since someone might not want to scale based on CPU).

nineinchnick commented 1 month ago

Also, please remove the feat: from the commit message. I update the PR title, you can use it as the commit message.