trinodb / charts

Apache License 2.0
151 stars 173 forks source link

Allow setting nodePort in .Values.coordinator.additionalExposedPorts #241

Closed jdmedeiros closed 1 month ago

jdmedeiros commented 1 month ago

When deploying on Kubernetes I was faced with additionalExposedPorts nodePorts that kept changing after each deploy due to the nodePort not being specified in the Helm chart, as explained here https://trinodb.slack.com/archives/CGB0QHWSW/p1727943085442609?thread_ts=1722396654.245879&cid=CGB0QHWSW

The purpose of this pull request is to allow something like:

  additionalExposedPorts:
    https:
      servicePort: 8443
      name: https
      port: 8443
      nodePort: 30443
      protocol: TCP

not only for https but also for other services.

cla-bot[bot] commented 1 month ago

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

nineinchnick commented 1 month ago

@cla-bot check

cla-bot[bot] commented 1 month ago

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

cla-bot[bot] commented 1 month ago

The cla-bot has been summoned, and re-checked this pull request!

jdmedeiros commented 1 month ago

@nineinchnick I submitted the CLA the same day I did the PR. Thanks.

nineinchnick commented 1 month ago

@cla-bot check

cla-bot[bot] commented 1 month ago

The cla-bot has been summoned, and re-checked this pull request!