search

trinodb / charts

Apache License 2.0
151 stars 173 forks source link

Add deployment spec properties to coordinator and worker #244

Closed amarthey closed 1 month ago

amarthey commented 1 month ago

Reference PR: #236

Adding deployment spec values for coordinator deployment and worker deployment:

 - progressDeadlineSeconds
 - revisionHistoryLimit
 - strategy

This is needed for us in case of an update of Trino Cluster that requires the deployment to bring pods up and down.

amarthey commented 1 month ago

Sorry @nineinchnick , I re-opened a PR because I messed up the rebase and squash from #236 .

amarthey commented 1 month ago

@nineinchnick let me know if the commit message is correct. I looked in the previous merged PRs and saw that usually commit message and PR title were matching.

mosabua commented 1 month ago

"more deployment properties" is too vague

You can have a short title and then a paragraph with more info if desired. But is should not be vague. See more info at https://trino.io/development/process#pull-request-and-commit-guidelines-