search

trinodb / charts

Apache License 2.0
151 stars 173 forks source link

Add support for Database resource group manager #252

Closed yassan closed 4 days ago

yassan commented 2 weeks ago

This PR enhances the Trino Helm chart by adding support for the Database resource group manager. Previously, only file-based configurations using ConfigMap were supported.

Additionally, the implementation is closely modeled after the existing accessControl pattern in the chart, ensuring consistency in the configuration approach.

Limitations

In the process of implementing this feature, we considered deploying the MySQL container in the same namespace as Trino to streamline configuration. However, the MySQL service endpoint URL includes the namespace, making it challenging to set a dynamic reference. To maintain stability and avoid complex configurations, we fixed the MySQL namespace as mysql, ultimately deciding against further attempts at a flexible namespace solution for this PR.

yassan commented 2 weeks ago

I noticed the CI is failing on the graceful_shutdown test case, which seems unrelated to this PR. Should this PR address it, or would it be better to handle it separately?

yassan commented 2 weeks ago

@nineinchnick All issues have been addressed. Could you please review again?