trinodb / charts

Apache License 2.0
151 stars 173 forks source link

Allow adding custom annotations for coordinator and worker deployment #254

Closed surendragalwa closed 4 days ago

surendragalwa commented 1 week ago

Trino helm chart does not allow adding custom deployment annotations to deployment metadata similar to service. The deployment helm chart does not have any reference to metadata annotation - see here

Why is it needed? As per Trino documentation, it is recommended to configure the catalog credentials in environments variables through secrets. So the catalog configuration can reference it as ${ENV:DB_PASSWORD}

When the kubernetes secret gets updated, the environment variables do not get updated causing authentication failure. This condition need manual restart/redeployment.

This can be automated using a kubernetes controller named stakater. But this needs addition of an annotation in deployment metadata as following -

kind: Deployment
metadata:
  name: foo
  annotations:
    reloader.stakater.com/auto: "true"
spec:
  template:
    metadata:

In order to use this, trino helm chart should allow adding custom annotation or maybe we can provide this annotation in default configuration.