search

trinodb / charts

Apache License 2.0
151 stars 174 forks source link

Enable password authentication if other authentication methods are also set #86

Closed FleischerT closed 6 months ago

FleischerT commented 1 year ago

The issue with password authentication working only when it is set as the only authentication type has been fixed. Since now in the templates it checks for a substring instead of equality.

Furthermore, it is now possible to use an externally created secret for the password file.

cla-bot[bot] commented 1 year ago

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

FleischerT commented 1 year ago

@cla-bot check

cla-bot[bot] commented 1 year ago

The cla-bot has been summoned, and re-checked this pull request!

nineinchnick commented 6 months ago

Ah I just noticed #124 is merged, this might not be needed anymore.