search

trinodb / charts

Apache License 2.0
151 stars 174 forks source link

Add secretMounts for the coordinator and worker #98

Closed hagaibarel closed 1 year ago

hagaibarel commented 1 year ago

Supersedes and closes #79 and #46 as well, see there for additional details and discussions

hagaibarel commented 1 year ago

@mosabua would love a review here, I know it's a feature a lot of users are waiting for (us included)

mosabua commented 1 year ago

I think this all looks good. Wdyt @losipiuk

hagaibarel commented 1 year ago

All the checks look green, not sure what linting errors are you referring to

losipiuk commented 1 year ago

All the checks look green, not sure what linting errors are you referring to

Looks fine now. Not sure what I saw back then. Maybe I noticed linter issues on intermediate commits. Not a big deal

losipiuk commented 1 year ago

Please squash the commits to one.

hagaibarel commented 1 year ago

Thanks a lot folks!