search

trinodb / tpch

Port of TPC-H dbgen to Java
44 stars 45 forks source link

Expose unscaled numeric values #12

Closed sopel39 closed 9 years ago

sopel39 commented 9 years ago

Unscaled numeric values are used to build decimal values in TPCH connector.

sopel39 commented 9 years ago

related issue https://github.com/facebook/presto/issues/3557 FYI: @martint @dain @cberner

dain commented 9 years ago

Can you rename the currency ones to getFooInCents and the discount/tax ones to getFooPercent?

sopel39 commented 9 years ago

@dain I have updated the commit, please take a look

sopel39 commented 9 years ago

@dain fixed

dain commented 9 years ago

Merged, thanks!

dain commented 9 years ago

Do you need any other changes before I release?

sopel39 commented 9 years ago

That's the only non-Presto change, thanks.

dain commented 9 years ago

This is released as 0.5