search

trinodb / tpch

Port of TPC-H dbgen to Java
44 stars 45 forks source link

Use parametrized varchar type #16

Closed losipiuk closed 8 years ago

losipiuk commented 8 years ago

@electrum please take a look. This is preparatory work to expose parameterized VARCHAR(x) columns from Presto TPC-H connector.

dain commented 8 years ago

Looks like there are build errors in Travis

losipiuk commented 8 years ago

It failed because airlift-tpch uses java 7 and used java.util.Optional and compiled with jdk 8. I changed it to use guava's Optional. But maybe it is better to bump java release version. Is there a reason to keep it at 7?

losipiuk commented 8 years ago

Draft of PR which makes use of this one in presto is here: https://github.com/prestodb/presto/pull/5012. I will update it to use proper (non-snapshot) version of airlift-tpch as soon as it is released.

martint commented 8 years ago

No, we should just move it to Java 8. The Travis job is probably just misconfigured.

losipiuk commented 8 years ago

New version which bumps java in pom.xml and .travis.yml to 1.8 and is based on java.util.Optional.