trinodb / tpch

Port of TPC-H dbgen to Java
44 stars 45 forks source link

Migrate from TravisCI to GitHub Actions #26

Closed winio94 closed 2 years ago

winio94 commented 2 years ago

Hi @hashhar, can You please review this PR for https://github.com/trinodb/trino/issues/10851 ? BTW I am unable to run mvn tests locally. I'm getting loads of checkstyle violation errors:

mvn test
...
[ERROR] src\test\java\io\trino\tpch\TestTpchTable.java:[32] (regexp) RegexpMultiline: Line contains carriage return
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  14.402 s
[INFO] Finished at: 2022-02-12T20:14:55+01:00
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-checkstyle-plugin:3.1.0:check (checkstyle) on project tpch: You have 6333 Checkstyle violations. -> [
Help 1]

Everything works when running by github actions, do You know what may be a cause? Here is my configuraton:

mvn -v
Apache Maven 3.8.4 (9b656c72d54e5bacbed989b64718c159fe39b537)
Maven home: C:\Program Files\apache-maven-3.8.4
Java version: 1.8.0_201, vendor: Oracle Corporation, runtime: C:\Program Files\Java\jdk1.8.0_201\jre
Default locale: pl_PL, platform encoding: Cp1250
OS name: "windows 8.1", version: "6.3", arch: "amd64", family: "windows"

Another fun fact - I was unable to compile the project when using JDK 11

Fixes https://github.com/trinodb/trino/issues/10851

cla-bot[bot] commented 2 years ago

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please submit the signed CLA to cla@trino.io. For more information, see https://github.com/trinodb/cla.

kokosing commented 2 years ago

RegexpMultiline: Line contains carriage return

Are you using windows?

winio94 commented 2 years ago

@kokosing

Are you using windows?

Ahh yes, so it is complaing at windows line separators, thanks for a suggesion

cla-bot[bot] commented 2 years ago

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please submit the signed CLA to cla@trino.io. For more information, see https://github.com/trinodb/cla.

winio94 commented 2 years ago

@martint I have sent signed CLA scan to cla@trino.io. When can I expect to be added to contributors list?

hashhar commented 2 years ago

@cla-bot check

cla-bot[bot] commented 2 years ago

The cla-bot has been summoned, and re-checked this pull request!

hashhar commented 2 years ago

Thank you for your contribution @winio94.