search

trinodb / trino-gateway

https://trinodb.github.io/trino-gateway/
Apache License 2.0
122 stars 48 forks source link

Ensure inclusion of UI in JAR and container artifacts #337

Closed andythsu closed 1 month ago

andythsu commented 1 month ago

Description

Additional context and related issues

Release notes

( ) This is not user-visible or is docs only, and no release notes are required. ( ) Release notes are required. Please propose a release note for me. ( ) Release notes are required, with the following suggested text:

*
mosabua commented 1 month ago

Worked with @andythsu - we think we got a cleaner solution. He is testing and will update PR.

andythsu commented 1 month ago

This is working fine for me. Would like to get someone else to test it

mosabua commented 1 month ago

Building locally from scratch I get

jar tvf gateway-ha-9-SNAPSHOT-jar-with-dependencies.jar  | grep static
     0 Wed May 08 13:15:04 PDT 2024 static/
   460 Wed May 08 13:15:04 PDT 2024 static/index.html
     0 Wed May 08 13:15:04 PDT 2024 static/assets/
2464900 Wed May 08 13:15:04 PDT 2024 static/assets/index-jdJ8WnTU.js
428462 Wed May 08 13:15:04 PDT 2024 static/assets/index-WjKhXYTT.css
  9457 Wed May 08 13:15:04 PDT 2024 static/logo.svg

I tried firing up the jar directly with the quickstart setup (without the db but anyway) - all good - I do get the UI.

I built the docker container and fired it up with docker compose and that worked as well and showed the UI.

mosabua commented 1 month ago

Lets change commit message to

"Fix build to ensure inclusion of UI in artifacts"

or just

"Ensure inclusion of UI in artifacts"

or

"Ensure inclusion of UI in JAR and container artifacts"

thoughts @colebow ?