Closed Chaho12 closed 4 weeks ago
Please check CI failure:
Error: TestLbAuthenticator.testNoLdapNoPresetUsers:122 » NullPointer Cannot invoke "java.util.Map.forEach(java.util.function.BiConsumer)" because "pagePermissions" is null
Error: TestLbAuthenticator.testWrongLdapConfig:131 » NullPointer Cannot invoke "java.util.Map.forEach(java.util.function.BiConsumer)" because "pagePermissions" is null
Please fix CI failure:
Error: TestLbAuthenticator.testNoLdapNoPresetUsers:122 » NullPointer Cannot invoke "java.util.Map.entrySet()" because "pagePermissions" is null
Error: TestLbAuthenticator.testWrongLdapConfig:131 » NullPointer Cannot invoke "java.util.Map.entrySet()" because "pagePermissions" is null
Please fix CI failure:
Error: src/main/java/io/trino/gateway/ha/security/LbOAuthManager.java:[52,1] (imports) ImportOrder: Wrong order for 'com.google.common.collect.ImmutableMap.toImmutableMap' import.
I pushed small changes because the indentation was wrong.
Description
Since both roles in web & security context are in upper-case, page permission should also be in upper case to match with roles.
Without this patch, user has to set upper-case key's in yaml in their yaml file as below, which is awkward as all other auth related confs are in lower-case.
Additional context and related issues
Release notes
(x) This is not user-visible or is docs only, and no release notes are required. ( ) Release notes are required. Please propose a release note for me. ( ) Release notes are required, with the following suggested text:
Test