search

trinodb / trino-gateway

https://trinodb.github.io/trino-gateway/
Apache License 2.0
143 stars 57 forks source link

Add support for OpenTelemetry #46

Open mosabua opened 11 months ago

mosabua commented 11 months ago

after dependencies like dropwizard are updated.

Needs architectural discussion how to best add this feature. Probably should talk to @electrum who added this to Trino.

@vishalya is interested on working on this feature.

mosabua commented 11 months ago

@martint mentioned that this will be easier if we migrate to Airlift instead of using Dropwizard

Also fyi @willmostly

lambrospetrou commented 10 months ago

This would be amazing to have. I have been looking to see if the gateway publishes metrics somehow that we could get them from outside, without implementing a custom listener module similar to ClusterStateListenerModule with our own ClusterStatsObserver.

Ideally, we would like to get those cluster stats metrics (and anything else from the gateway) without having to add any code in the gateway itself (or having code that depends on the gateway jar due to weird repo issues on our side), so that we can use the published gateway as-is, and then own the monitoring infra from the outside.

mosabua commented 4 months ago

This depends on our move to airlift - see #41

mosabua commented 2 months ago

Hey @mattstep .. Trino Gateway main branch is now on airlift .. wanna throw a PR for adding OpenTelemetry support our way that is consistent with the approach you took in Trino?