search

trinodb / trino-gateway

https://trinodb.github.io/trino-gateway/
Apache License 2.0
160 stars 72 forks source link

Replace blackListHeaders with excludeHeaders #470

Closed Chaho12 closed 1 month ago

Chaho12 commented 2 months ago

Description

Use excludeHeaders instead as blacklist isn't recommended in software projects.

Additional context and related issues

Release notes

( ) This is not user-visible or is docs only, and no release notes are required. ( ) Release notes are required. Please propose a release note for me. (x) Release notes are required, with the following suggested text:

* Replace `blackListHeaders` with `excludeHeaders` in the routing rule configuration
mosabua commented 2 months ago

Agreed .. this is a good change @Chaho12

ebyhr commented 2 months ago
  • Use excludeHeaders instead of blackListHeaders

Thanks for writing a release note entry. I would recommend mentioning where the excludeHeaders is used, e.g. "Use Replace blackListHeaders with excludeHeaders in the routing rule configuration"

mosabua commented 2 months ago

please rebase and address the few small comments @Chaho12 .. then we can merge

ebyhr commented 1 month ago

Use excludeHeaderList instead of blackListHeaders #470

Please update the PR title.