trinodb / trino-gateway

https://trinodb.github.io/trino-gateway/
Apache License 2.0
160 stars 72 forks source link

Add monitorType JMX #472

Open alaturqua opened 2 months ago

alaturqua commented 2 months ago

Description

This pull request introduces a new monitorType for JMX-based monitoring in Trino Gateway. It includes documentation and configuration details for retrieving cluster information using specific JMX metrics.

Details

Release notes

( ) This is not user-visible or is docs only, and no release notes are required. (x) Release notes are required. Please propose a release note for me. ( ) Release notes are required, with the following suggested text:

* 
alaturqua commented 2 months ago

I am not very experienced with Java and Testing in Java. Please feel free to add tests.

alaturqua commented 1 month ago

Thanks for the reviews. I was on vacation and didn't have time to implement the requested changes yet. I will take care of them in the next days.

I might need some support to activate the /v1/jmx/mbean endpoint in the test environment for testing.

willmostly commented 2 weeks ago

@alaturqua please ping me when this is ready for another look

alaturqua commented 6 hours ago

I had to sync my fork to be able to change my PR. But it got automatically closed, when I did so. I am reopening.