trinodb / trino-gateway

https://trinodb.github.io/trino-gateway/
Apache License 2.0
160 stars 72 forks source link

Update docs to add encoding header to be excluded #489

Closed Chaho12 closed 1 month ago

Chaho12 commented 1 month ago

Description

When decoding JSON response using io.airlift.http.client#createJsonResponseHandler at external routing group selector code, JSON response could be compressed in GZIP (or whatever format) depending on the network configuration.

This is not expecected behaviour by Airlift as it read bytes.

So, I suggest adding 'Accept-Encoding' to docs so that user can know they might need to exclude it when making API request to server.

Additional context and related issues

Release notes

(x) This is not user-visible or is docs only, and no release notes are required. ( ) Release notes are required. Please propose a release note for me. ( ) Release notes are required, with the following suggested text:

* 
ebyhr commented 1 month ago

@mosabua Gentle reminder.