Support `USE catalog.schema` statements

trinodb / trino-python-client

Python client for Trino

Apache License 2.0

328 stars 163 forks source link

Support `USE catalog.schema` statements #175

Closed mdesmet closed 2 years ago

mdesmet commented 2 years ago

Fixes #153

mdesmet commented 2 years ago

Not sure why the build failed in 3.10 on the following error:

trino.exceptions.TrinoUserError: TrinoUserError(type=USER_ERROR, name=COLUMN_NOT_FOUND, message="line 1:8: Column 'current_catalog' cannot be resolved", query_id=20220424_155121_00213_82y8r)

ebyhr commented 2 years ago

current_catalog was added in version 357, so it fails on 351. https://trino.io/docs/current/release/release-357.html

mdesmet commented 2 years ago

I have rebased the code and made following changes:

ClientSession is now thread-safe. it is initiated by the dbapi.Connection and some of its properties can be modified based on the headers coming back from the Trino server. It can later on be extended with more modifiable properties.
Added tests for both USE catalog.schema and USE schema
Improved mypy typing for ClientSession class

ebyhr commented 2 years ago

Merged, thanks!