search

trinodb / trino-python-client

Python client for Trino
Apache License 2.0
328 stars 163 forks source link

Add support for SET ROLE statement #196

Closed ulisesojeda closed 2 years ago

ulisesojeda commented 2 years ago

Add support for SET ROLE statement

Fixes #7

cla-bot[bot] commented 2 years ago

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please submit the signed CLA to cla@trino.io. For more information, see https://github.com/trinodb/cla.

ebyhr commented 2 years ago

set role

Please update the commit title as "Add support for SET ROLE statement "

cla-bot[bot] commented 2 years ago

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please submit the signed CLA to cla@trino.io. For more information, see https://github.com/trinodb/cla.

cla-bot[bot] commented 2 years ago

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please submit the signed CLA to cla@trino.io. For more information, see https://github.com/trinodb/cla.

ulisesojeda commented 2 years ago

Thanks for your contribution. Can you share the integration test code & result? Also, please submit CLA if you haven't sent it.

Done

ulisesojeda commented 2 years ago

Thanks for your contribution. Can you share the integration test code & result? Also, please submit CLA if you haven't sent it.

Hi @ebyhr. I'm not sure how to do the integration test. The docker image used for tests doesn't have a catalog that support role management. Any suggestion?

ebyhr commented 2 years ago

@ulisesojeda The easiest way is running HiveQueryRunner.main() method in https://github.com/trinodb/trino repository.

cla-bot[bot] commented 2 years ago

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please submit the signed CLA to cla@trino.io. For more information, see https://github.com/trinodb/cla.

ulisesojeda commented 2 years ago

@ulisesojeda The easiest way is running HiveQueryRunner.main() method in https://github.com/trinodb/trino repository.

@ebyhr ready the integration tests

cla-bot[bot] commented 2 years ago

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please submit the signed CLA to cla@trino.io. For more information, see https://github.com/trinodb/cla.

cla-bot[bot] commented 2 years ago

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please submit the signed CLA to cla@trino.io. For more information, see https://github.com/trinodb/cla.

cla-bot[bot] commented 2 years ago

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please submit the signed CLA to cla@trino.io. For more information, see https://github.com/trinodb/cla.

mdesmet commented 2 years ago

@ulisesojeda: Thanks for the great work already. We just merged a refactoring of the ClientSession. The ClientSession is now thread-safe and initiated within the dbapi.Connection. Could you rebase your code?

cla-bot[bot] commented 2 years ago

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please submit the signed CLA to cla@trino.io. For more information, see https://github.com/trinodb/cla.

cla-bot[bot] commented 2 years ago

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please submit the signed CLA to cla@trino.io. For more information, see https://github.com/trinodb/cla.

ulisesojeda commented 2 years ago

@ulisesojeda: Thanks for the great work already. We just merged a refactoring of the ClientSession. The ClientSession is now thread-safe and initiated within the dbapi.Connection. Could you rebase your code?

Hi @mdesmet . I'll create a new PR, I've spoiled this one with the rebase