Open john-bodley opened 2 years ago
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: John Bodley. This is most likely caused by a git client misconfiguration; please make sure to:
git config --list | grep email
git config --global user.email email@example.com
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: John Bodley. This is most likely caused by a git client misconfiguration; please make sure to:
git config --list | grep email
git config --global user.email email@example.com
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: John Bodley. This is most likely caused by a git client misconfiguration; please make sure to:
git config --list | grep email
git config --global user.email email@example.com
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: John Bodley. This is most likely caused by a git client misconfiguration; please make sure to:
git config --list | grep email
git config --global user.email email@example.com
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: John Bodley. This is most likely caused by a git client misconfiguration; please make sure to:
git config --list | grep email
git config --global user.email email@example.com
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: John Bodley. This is most likely caused by a git client misconfiguration; please make sure to:
git config --list | grep email
git config --global user.email email@example.com
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: John Bodley. This is most likely caused by a git client misconfiguration; please make sure to:
git config --list | grep email
git config --global user.email email@example.com
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: John Bodley. This is most likely caused by a git client misconfiguration; please make sure to:
git config --list | grep email
git config --global user.email email@example.com
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: John Bodley. This is most likely caused by a git client misconfiguration; please make sure to:
git config --list | grep email
git config --global user.email email@example.com
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: John Bodley. This is most likely caused by a git client misconfiguration; please make sure to:
git config --list | grep email
git config --global user.email email@example.com
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: John Bodley. This is most likely caused by a git client misconfiguration; please make sure to:
git config --list | grep email
git config --global user.email email@example.com
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: John Bodley. This is most likely caused by a git client misconfiguration; please make sure to:
git config --list | grep email
git config --global user.email email@example.com
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: John Bodley. This is most likely caused by a git client misconfiguration; please make sure to:
git config --list | grep email
git config --global user.email email@example.com
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: John Bodley. This is most likely caused by a git client misconfiguration; please make sure to:
git config --list | grep email
git config --global user.email email@example.com
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: John Bodley. This is most likely caused by a git client misconfiguration; please make sure to:
git config --list | grep email
git config --global user.email email@example.com
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: John Bodley. This is most likely caused by a git client misconfiguration; please make sure to:
git config --list | grep email
git config --global user.email email@example.com
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: John Bodley. This is most likely caused by a git client misconfiguration; please make sure to:
git config --list | grep email
git config --global user.email email@example.com
Thanks @hashhar and @hovaesco for the review. I’ve hopefully answered/addressed all your comments/questions.
I opted to downgrade the version of Poetry (from a pre-release to the latest stable version)—albeit it being less feature rich—to unblock the PR.
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: John Bodley. This is most likely caused by a git client misconfiguration; please make sure to:
git config --list | grep email
git config --global user.email email@example.com
Somewhat of a yak shaving exercise as I was initially going to look into https://github.com/trinodb/trino-python-client/issues/199 though realized that the
trino-python-client
package has no deterministic dependency management. See the Slack discussion here for more details.There's a slew of frameworks for handling Python dependencies including Pipenv, pip-tools, etc. however it seems like Poetry is well supported and integrates with
pyproject.toml
—a replacement for the legacysetup.py
. Per https://github.com/trinodb/trino-python-client/pull/201#discussion_r930220699, the importance is having a dependency manager rather than the dependency manager. If necessary is should be fairly trivial to later migrate to hatch or similar.This PR:
setup.py
in favor ofpyproject.toml
.poetry.lock
file.tox
—ensuring a consistent local and remote CI workflow.to: @bitsondatadev @hashhar