search

trinodb / trino-python-client

Python client for Trino
Apache License 2.0
311 stars 154 forks source link

Add JSON functionality to SQLAlchemy Dialect #214

Closed laserkaplan closed 1 year ago

laserkaplan commented 1 year ago

Description

Implement the ability to reference JSON columns using SQLAlchemy. This allows JSON columns to be created in new tables, as well as writes to/reads from them using normal Python json module serialization/deserialization.

Originally referenced in this issue.

Release notes

( ) This is not user-visible and no release notes are required. ( ) Release notes are required, please propose a release note for me. (x) Release notes are required, with the following suggested text:

* Add support for creating tables containing `JSON` columns and reading and writing to them with SQLAlchemy. ([#194](https://trinodb/trino-python-client/issues/194))
laserkaplan commented 1 year ago

Whoops, thanks for the reminder! Moved to datatype.py.

laserkaplan commented 1 year ago

Seems like these tests failing might be a larger issue? Multiple open PRs are all failing at the same spot.

mdesmet commented 1 year ago

Seems like these tests failing might be a larger issue? Multiple open PRs are all failing at the same spot.

Yes, it should be gone when #220 is merged.