search

trinodb / trino-python-client

Python client for Trino
Apache License 2.0
311 stars 154 forks source link

Don't automatically label issues #228

Closed hashhar closed 1 year ago

hashhar commented 1 year ago

Issues must be triaged before being labelled as a bug - which confirms it's a bug to be fixed instead of just using something wrong or being labelled as an enhancement - which confirms it's something we think should be added.

hashhar commented 1 year ago

We can auto-add a "triage" label to them however if it helps to identify which issues need to be looked at and which ones are already looked at.

mdesmet commented 1 year ago

We can auto-add a "triage" label to them however if it helps to identify which issues need to be looked at and which ones are already looked at.

I'm more in favour of adding a triage label, it would most clear towards every stakeholder in what stage the issue resides.

martint commented 1 year ago

Wouldn’t that be the default state of an issue? Why do we need a separate label?

mdesmet commented 1 year ago

My suggestion would be to add both triage and the issue type label (bug or enhancement) and then remove the triage label after triage counting on the fact that most issues will be correctly labeled by the issue reporter.

hashhar commented 1 year ago

@mdesmet That's rarely the case. Lots of issues are for troubleshooting or asking for a feature we don't plan to implement.

martint commented 1 year ago

Also, a triage label can be ambiguous. Triage for what purpose? When is triaging “done”? Is it just a way of saying “the bug/feature label is tentative” or does it also involve investigating, and reproducing a bug, or making a decision to move forward with a feature?