Closed mdesmet closed 2 years ago
@hovaesco: PTAL
@hashhar, @ebyhr : Please have a look. This is important for Galaxy users to be able to use sqlalchemy.
@hashhar : PTAL
@hashhar : PTAL. I have not added another class as it is a simple one liner using the typical json.loads recipe but looping through it and instantiating a tuple based on the array.
kwargs["extra_credential"] = [
tuple(extra_credential) for extra_credential in json.loads(unquote_plus(url.query["extra_credential"]))
]
Currently it is not possible to create a Trino url in sqlalchemy urls containing characters like &, ' ' or @. The values should be properly encoded and decoded.
This PR provides a helper method that properly encodes the passed values and ensures that values are properly decoded before passing down as
dbapi.connect
parameters.Release notes
( ) This is not user-visible and no release notes are required. ( ) Release notes are required, please propose a release note for me. (x) Release notes are required, with the following suggested text: