search

trinodb / trino-python-client

Python client for Trino
Apache License 2.0
311 stars 154 forks source link

Fix 'TableClause' object has no attribute 'dialect_options' #240

Closed mdesmet closed 1 year ago

mdesmet commented 1 year ago

Fixes #237

Release notes

( ) This is not user-visible and no release notes are required. ( ) Release notes are required, please propose a release note for me. (x) Release notes are required, with the following suggested text:

Resolved 'TableClause' object has no attribute 'dialect_options' exception by checking for DialectKWArgs implementation.

mdesmet commented 1 year ago

@hashhar: PTAL. It should fix an exception being thrown in Superset.

mdesmet commented 1 year ago

@ebyhr : PTAL, test has been added.

ebyhr commented 1 year ago

Merged, thanks!

georgewfisher commented 1 year ago

Should there be a PR to update Superset to require a minimum of 0.317.0?