search

trinodb / trino-python-client

Python client for Trino
Apache License 2.0
309 stars 151 forks source link

Add support for TIMEZONE #252

Closed ulisesojeda closed 1 year ago

ulisesojeda commented 1 year ago

Add support for TIMEZONE

Fixes https://github.com/trinodb/trino-python-client/issues/27

ulisesojeda commented 1 year ago

Thanks for this contribution, overall looks very good.

Note that this also should be documented.

Done the doc. Thanks for your review and comments @mdesmet !

mdesmet commented 1 year ago

@ulisesojeda : Please don't merge master into your branch but rebase on master.

ulisesojeda commented 1 year ago

@ebyhr @hashhar could you please check it?

ulisesojeda commented 1 year ago

LGTM % some comments.

Thanks for this.

I plan to not merge this for 0.320.0 so that other features can be part of 0.320.0 which people might be waiting for. Then 0.321.0 can introduce this change. I hope that's ok?

While there's a way to preserve old beahviour it requires someone to read release notes so I'd like to announce on Trino community before this change.

Sure. Thanks for the review @hashhar

hashhar commented 1 year ago

Rebased. Will merge once CI is done.