Fix 'Engine' object has no attribute 'connection'

trinodb / trino-python-client

Python client for Trino

Apache License 2.0

309 stars 151 forks source link

Fix 'Engine' object has no attribute 'connection' #255

Closed mdesmet closed 1 year ago

mdesmet commented 1 year ago

Description

Fixes #253

Non-technical explanation

Release notes

( ) This is not user-visible or docs only and no release notes are required. ( ) Release notes are required, please propose a release note for me. (x) Release notes are required, with the following suggested text:

* Fix 'Engine' object has no attribute 'connection', when calling `get_table_comment` from Superset with sqlalchemy 1.3

mdesmet commented 1 year ago

This issue seems to occur only in combination with sqlalchemy 1.3. So we better first merge #254

mdesmet commented 1 year ago

@hashhar : Added TODO and created follow up issue for comment support in sqlalchemy. See #256