Support `None` values in array, map and row types

trinodb / trino-python-client

Python client for Trino

Apache License 2.0

309 stars 151 forks source link

Support `None` values in array, map and row types #281

Closed mdesmet closed 1 year ago

mdesmet commented 1 year ago

Description

Fixes #269

Also refactors mappers from lambda functions to separate classes for better readability.

Non-technical explanation

Release notes

( ) This is not user-visible or docs only and no release notes are required. ( ) Release notes are required, please propose a release note for me. ( ) Release notes are required, with the following suggested text:

* Fix some things. ({issue}`issuenumber`)

hashhar commented 1 year ago

@ebyhr PTAL. Please avoid leaving comments on code that was moved from existing code - out of scope for this PR and I'm submitting another PR on top of this with some cleanups. will request a review there.

mdesmet commented 1 year ago

I made some further modifications:

simplified the code to only apply rounding if the input value exceeds Python's supported precision.
Removed usage of regex for performance
Usage of fromisoformat instead of strptotime to get a 54x boost in performance
Rounding using Decimal