Close http session on connection.close()

trinodb / trino-python-client

Python client for Trino

Apache License 2.0

309 stars 151 forks source link

Close http session on connection.close() #296

Closed mdesmet closed 1 year ago

mdesmet commented 1 year ago

Description

Fixes #294

Non-technical explanation

Release notes

(x) This is not user-visible or docs only and no release notes are required. ( ) Release notes are required, please propose a release note for me. ( ) Release notes are required, with the following suggested text:

mdesmet commented 1 year ago

Is the TODO not relevant anymore?

I have added the TODO again. It is still relevant. I removed it by accident. It is a potential use case I still need to try: keeping alive multiple queries in the same thread living in different cursor objects (more relevant for DML queries). Even with only just one running query, the connection object has no references to the created cursors, so there is no way to cancel them.

Maybe we should create an issue to open the discussion.