search

trinodb / trino-python-client

Python client for Trino
Apache License 2.0
309 stars 151 forks source link

Use local server if available #326

Closed mdesmet closed 1 year ago

mdesmet commented 1 year ago

Description

This PR will use the already locally running Trino server instead of starting a new instance for every module. This saves us some time running tests and is easier for debugging as the server is not stopped after running the tests and doesn't use a random port.

It also removes some (broken) legacy code for running tests and managing docker.

Non-technical explanation

Release notes

(x) This is not user-visible or docs only and no release notes are required. ( ) Release notes are required, please propose a release note for me. ( ) Release notes are required, with the following suggested text:

* Fix some things. ({issue}`issuenumber`)
hashhar commented 1 year ago

Can you update DEVELOPMENT.md (https://github.com/trinodb/trino-python-client/blob/master/.github/DEVELOPMENT.md#running-tests) to mention how to use local Trino server?

hashhar commented 1 year ago

LGTM otherwise.