search

trinodb / trino-python-client

Python client for Trino
Apache License 2.0
307 stars 151 forks source link

Add support for trino catalog when autoloading table metadata #390

Closed cpcloud closed 10 months ago

cpcloud commented 12 months ago

Description

Support autoloading metadata from different catalogs.

Fixes #389.

Non-technical explanation

Users can now load metadata from a catalog that is different from the one they initially connected to.

Release notes

( ) This is not user-visible or docs only and no release notes are required. ( ) Release notes are required, please propose a release note for me. (x) Release notes are required, with the following suggested text: 

* Support autoloading metadata from different catalogs using sqlalchemy Table autoloading.
cla-bot[bot] commented 12 months ago

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

cpcloud commented 12 months ago

I've sent over the signed CLA.

mosabua commented 12 months ago

Thanks @cpcloud .. @martint will process the CLA.

Fyi @aalbu and @hashhar .. this is going to be used in Ibis and other tools probably. See https://github.com/trinodb/trino.io/pull/474

cla-bot[bot] commented 11 months ago

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

cpcloud commented 11 months ago

@mosabua It looks like I am getting the CLA note again. Did my CLA go through?

hashhar commented 11 months ago

@martint PTAL about the CLA.

hashhar commented 11 months ago

@cpcloud the tests are still red.

@cla-bot check

cla-bot[bot] commented 11 months ago

The cla-bot has been summoned, and re-checked this pull request!

hovaesco commented 10 months ago

Hi @cpcloud are you planning to continue the work on this PR?

cpcloud commented 10 months ago

@hovaesco I am not. I found a way to do what I wanted without this PR.

olp966220 commented 7 months ago

summoned

Could you share the way?