trinodb / trino-python-client

Python client for Trino
Apache License 2.0
327 stars 163 forks source link

add an option to deferred fetch result in Cursor.execute() #400

Open dungdm93 opened 1 year ago

dungdm93 commented 1 year ago

After introduce in #220, all query are now until at least one row is received or query is finished or cancelled. In some cases such as Superset, users would like to be able to cancel the query but the execution still going on.

See also: apache/superset#24913 Fix: apache/superset#24858

giftig commented 1 year ago

This probably needs unit test coverage as well.

dungdm93 commented 1 year ago

Test added

dungdm93 commented 1 year ago

Hi @mdesmet, @hashhar, could you help me review this PR.

mdesmet commented 1 year ago

@dungdm93 : Can you handle the open comments?