search

trinodb / trino

Official repository of Trino, the distributed SQL query engine for big data, formerly known as PrestoSQL (https://trino.io)
https://trino.io
Apache License 2.0
10.19k stars 2.94k forks source link

Add support for varchar and date types to kudu connector #11009

Open grantatspothero opened 2 years ago

grantatspothero commented 2 years ago

Kudu version 1.15.0 now supports varchar and date types but reading these types from trino is unsupported.

Currently writing trino varchar/date types is possible but they get converted to strings when writing to kudu: https://trino.io/docs/current/connector/kudu.html#data-type-mapping

Some thought should be given to the write path. For example, writing trino date as a kudu date is the best path forward but breaks backwards compatibility. Maybe a config option should be introduced?

See this PR comment for context: https://github.com/trinodb/trino/pull/10940#discussion_r799721560

grantatspothero commented 2 years ago

Someone tried adding support for these types previously in this PR: https://github.com/trinodb/trino/pull/8229/files

ebyhr commented 1 month ago

Reopened because there're 2 TODO comments mentioning https://github.com/trinodb/trino/issues/11009 in TypeHelper and KuduTableProperties.