search

trinodb / trino

Official repository of Trino, the distributed SQL query engine for big data, formerly known as PrestoSQL (https://trino.io)
https://trino.io
Apache License 2.0
10.21k stars 2.94k forks source link

UPDATE failed in Iceberg: Multiple entries with same key: 3=$row_id.file_record_count #15952

Open fritzb opened 1 year ago

fritzb commented 1 year ago

Update from trino CLI failed with error Multiple entries with same key: 3=$row_id.file_record_count and 3=metric_process_timestamp. I have Flink writer with equalityFieldColumns configured. metric_process_timestamp is a timestamp(6) type. The table do not have any complex type. It's either timestamp(6), double, int, or string. Trino is 406, Iceberg is 1.0.0, Flink 1.13

Here is the Flink snippet code:

    FlinkSink.forRowData(stream.map(x -> RowHelper.convertProtoToRowData(x,
                    MapMakingMetricUtils.NON_NULL_COLUMNS,
                    Collections.EMPTY_LIST, true)))
            .tableLoader(tableLoader)
            .equalityFieldColumns(Arrays
                    .asList("meta_data_center", "meta_namespace", "metric_timestamp", "name", "sequence_id"))
            .upsert(true)
            .append()
            .name(sinkNameExtension + "-iceberg");

Here are the error message:

trino> update metrics.map_making_metrics set meta_row_state = 0;

Query 20230202_164316_00015_687bi, FAILED, 3 nodes
http://trino.dev.deepmap.ai/ui/query.html?20230202_164316_00015_687bi
Splits: 195 total, 22 done (11.28%)
CPU Time: 0.3s total, 14.8K rows/s, 4.89MB/s, 25% active
Per Node: 0.1 parallelism, 2.06K rows/s,  698KB/s
Parallelism: 0.4
Peak Memory: 3.18MB
0.78 [4.83K rows, 1.59MB] [6.19K rows/s, 2.04MB/s]

Query 20230202_164316_00015_687bi failed: Multiple entries with same key: 3=$row_id.file_record_count and 3=metric_process_timestamp
io.trino.spi.TrinoException: Multiple entries with same key: 3=$row_id.file_record_count and 3=metric_process_timestamp
    at io.trino.plugin.iceberg.IcebergPageSource.getNextPage(IcebergPageSource.java:179)
    at io.trino.plugin.base.classloader.ClassLoaderSafeUpdatablePageSource.getNextPage(ClassLoaderSafeUpdatablePageSource.java:79)
    at io.trino.operator.ScanFilterAndProjectOperator$ConnectorPageSourceToPages.process(ScanFilterAndProjectOperator.java:400)
    at io.trino.operator.WorkProcessorUtils$ProcessWorkProcessor.process(WorkProcessorUtils.java:391)
    at io.trino.operator.WorkProcessorUtils.getNextState(WorkProcessorUtils.java:240)
    at io.trino.operator.WorkProcessorUtils$YieldingProcess.process(WorkProcessorUtils.java:182)
    at io.trino.operator.WorkProcessorUtils$ProcessWorkProcessor.process(WorkProcessorUtils.java:391)
    at io.trino.operator.WorkProcessorUtils$3.process(WorkProcessorUtils.java:325)
    at io.trino.operator.WorkProcessorUtils$ProcessWorkProcessor.process(WorkProcessorUtils.java:391)
    at io.trino.operator.WorkProcessorUtils$3.process(WorkProcessorUtils.java:325)
    at io.trino.operator.WorkProcessorUtils$ProcessWorkProcessor.process(WorkProcessorUtils.java:391)
    at io.trino.operator.WorkProcessorUtils$3.process(WorkProcessorUtils.java:325)
    at io.trino.operator.WorkProcessorUtils$ProcessWorkProcessor.process(WorkProcessorUtils.java:391)
    at io.trino.operator.WorkProcessorUtils$3.process(WorkProcessorUtils.java:325)
    at io.trino.operator.WorkProcessorUtils$ProcessWorkProcessor.process(WorkProcessorUtils.java:391)
    at io.trino.operator.WorkProcessorUtils.lambda$flatten$7(WorkProcessorUtils.java:296)
    at io.trino.operator.WorkProcessorUtils$3.process(WorkProcessorUtils.java:338)
    at io.trino.operator.WorkProcessorUtils$ProcessWorkProcessor.process(WorkProcessorUtils.java:391)
    at io.trino.operator.WorkProcessorUtils$3.process(WorkProcessorUtils.java:325)
    at io.trino.operator.WorkProcessorUtils$ProcessWorkProcessor.process(WorkProcessorUtils.java:391)
    at io.trino.operator.WorkProcessorUtils.getNextState(WorkProcessorUtils.java:240)
    at io.trino.operator.WorkProcessorUtils.lambda$processStateMonitor$3(WorkProcessorUtils.java:219)
    at io.trino.operator.WorkProcessorUtils$ProcessWorkProcessor.process(WorkProcessorUtils.java:391)
    at io.trino.operator.WorkProcessorUtils.getNextState(WorkProcessorUtils.java:240)
    at io.trino.operator.WorkProcessorUtils.lambda$finishWhen$4(WorkProcessorUtils.java:234)
    at io.trino.operator.WorkProcessorUtils$ProcessWorkProcessor.process(WorkProcessorUtils.java:391)
    at io.trino.operator.WorkProcessorSourceOperatorAdapter.getOutput(WorkProcessorSourceOperatorAdapter.java:150)
    at io.trino.operator.Driver.processInternal(Driver.java:411)
    at io.trino.operator.Driver.lambda$process$10(Driver.java:314)
    at io.trino.operator.Driver.tryWithLock(Driver.java:706)
    at io.trino.operator.Driver.process(Driver.java:306)
    at io.trino.operator.Driver.processForDuration(Driver.java:277)
    at io.trino.execution.SqlTaskExecution$DriverSplitRunner.processFor(SqlTaskExecution.java:752)
    at io.trino.execution.executor.PrioritizedSplitRunner.process(PrioritizedSplitRunner.java:164)
    at io.trino.execution.executor.TaskExecutor$TaskRunner.run(TaskExecutor.java:519)
    at io.trino.$gen.Trino_405____20230130_193035_2.run(Unknown Source)
    at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136)
    at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635)
    at java.base/java.lang.Thread.run(Thread.java:833)
Caused by: java.lang.IllegalArgumentException: Multiple entries with same key: 3=$row_id.file_record_count and 3=metric_process_timestamp
    at org.apache.iceberg.relocated.com.google.common.collect.ImmutableMap.conflictException(ImmutableMap.java:377)
    at org.apache.iceberg.relocated.com.google.common.collect.ImmutableMap.checkNoConflict(ImmutableMap.java:371)
    at org.apache.iceberg.relocated.com.google.common.collect.RegularImmutableMap.checkNoConflictInKeyBucket(RegularImmutableMap.java:241)
    at org.apache.iceberg.relocated.com.google.common.collect.RegularImmutableMap.fromEntryArrayCheckingBucketOverflow(RegularImmutableMap.java:132)
    at org.apache.iceberg.relocated.com.google.common.collect.RegularImmutableMap.fromEntryArray(RegularImmutableMap.java:94)
    at org.apache.iceberg.relocated.com.google.common.collect.ImmutableMap$Builder.build(ImmutableMap.java:573)
    at org.apache.iceberg.relocated.com.google.common.collect.ImmutableMap$Builder.buildOrThrow(ImmutableMap.java:601)
    at org.apache.iceberg.relocated.com.google.common.collect.ImmutableMap$Builder.build(ImmutableMap.java:588)
    at org.apache.iceberg.types.IndexByName.byId(IndexByName.java:81)
    at org.apache.iceberg.types.TypeUtil.indexNameById(TypeUtil.java:160)
    at org.apache.iceberg.Schema.lazyIdToName(Schema.java:183)
    at org.apache.iceberg.Schema.<init>(Schema.java:112)
    at org.apache.iceberg.Schema.<init>(Schema.java:91)
    at org.apache.iceberg.Schema.<init>(Schema.java:83)
    at org.apache.iceberg.Schema.<init>(Schema.java:79)
    at io.trino.plugin.iceberg.IcebergUtil.schemaFromHandles(IcebergUtil.java:248)
    at io.trino.plugin.iceberg.delete.EqualityDeleteFilter.createPredicate(EqualityDeleteFilter.java:49)
    at io.trino.plugin.iceberg.IcebergPageSourceProvider.lambda$createPageSource$7(IcebergPageSourceProvider.java:350)
    at java.base/java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:197)
    at java.base/java.util.ArrayList$ArrayListSpliterator.forEachRemaining(ArrayList.java:1625)
    at java.base/java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:509)
    at java.base/java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:499)
    at java.base/java.util.stream.ReduceOps$ReduceOp.evaluateSequential(ReduceOps.java:921)
    at java.base/java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)
    at java.base/java.util.stream.ReferencePipeline.reduce(ReferencePipeline.java:662)
    at io.trino.plugin.iceberg.IcebergPageSourceProvider.lambda$createPageSource$8(IcebergPageSourceProvider.java:351)
    at com.google.common.base.Suppliers$NonSerializableMemoizingSupplier.get(Suppliers.java:183)
    at io.trino.plugin.iceberg.IcebergPageSource.getNextPage(IcebergPageSource.java:162)
    ... 38 more

trino>
findepi commented 1 year ago

I think this is the same issue as https://github.com/trinodb/trino/issues/14836

fritzb commented 1 year ago

@findepi I applied the patch from #14836 and I still getting the exception. I think #14836 addressed issue with complex data structure (map, array) and I do not have any complex type columns in the schema.

here are the steps:

  1. create the table using trino (no equality configuration)
  2. use flink with equality, and then UPSERT
  3. use trino cli to update all rows
trino> update metrics.map_making_metrics set meta_row_state = 0;

Query 20230209_050316_00004_u7pum, FAILED, 3 nodes
http://trino.dev.deepmap.ai/ui/query.html?20230209_050316_00004_u7pum
Splits: 95 total, 0 done (0.00%)
CPU Time: 0.1s total, 5.31K rows/s,  211KB/s, 35% active
Per Node: 0.0 parallelism,   226 rows/s, 9.03KB/s
Parallelism: 0.1
Peak Memory: 1022KB
0.93 [632 rows, 25.2KB] [680 rows/s, 27.1KB/s]

Query 20230209_050316_00004_u7pum failed: Multiple entries with same key: 2147483646=$row_id._file and 2147483646=_file
io.trino.spi.TrinoException: Multiple entries with same key: 2147483646=$row_id._file and 2147483646=_file
    at io.trino.plugin.iceberg.IcebergPageSource.getNextPage(IcebergPageSource.java:142)
    at io.trino.operator.ScanFilterAndProjectOperator$ConnectorPageSourceToPages.process(ScanFilterAndProjectOperator.java:387)
    at io.trino.operator.WorkProcessorUtils$ProcessWorkProcessor.process(WorkProcessorUtils.java:413)
    at io.trino.operator.WorkProcessorUtils.getNextState(WorkProcessorUtils.java:262)
    at io.trino.operator.WorkProcessorUtils$YieldingProcess.process(WorkProcessorUtils.java:182)
    at io.trino.operator.WorkProcessorUtils$ProcessWorkProcessor.process(WorkProcessorUtils.java:413)
    at io.trino.operator.WorkProcessorUtils$3.process(WorkProcessorUtils.java:347)
    at io.trino.operator.WorkProcessorUtils$ProcessWorkProcessor.process(WorkProcessorUtils.java:413)
    at io.trino.operator.WorkProcessorUtils$3.process(WorkProcessorUtils.java:347)
    at io.trino.operator.WorkProcessorUtils$ProcessWorkProcessor.process(WorkProcessorUtils.java:413)
    at io.trino.operator.WorkProcessorUtils$3.process(WorkProcessorUtils.java:347)
    at io.trino.operator.WorkProcessorUtils$ProcessWorkProcessor.process(WorkProcessorUtils.java:413)
    at io.trino.operator.WorkProcessorUtils.getNextState(WorkProcessorUtils.java:262)
    at io.trino.operator.WorkProcessorUtils$BlockingProcess.process(WorkProcessorUtils.java:208)
    at io.trino.operator.WorkProcessorUtils$ProcessWorkProcessor.process(WorkProcessorUtils.java:413)
    at io.trino.operator.WorkProcessorUtils.lambda$flatten$6(WorkProcessorUtils.java:318)
    at io.trino.operator.WorkProcessorUtils$3.process(WorkProcessorUtils.java:360)
    at io.trino.operator.WorkProcessorUtils$ProcessWorkProcessor.process(WorkProcessorUtils.java:413)
    at io.trino.operator.WorkProcessorUtils$3.process(WorkProcessorUtils.java:347)
    at io.trino.operator.WorkProcessorUtils$ProcessWorkProcessor.process(WorkProcessorUtils.java:413)
    at io.trino.operator.WorkProcessorUtils.getNextState(WorkProcessorUtils.java:262)
    at io.trino.operator.WorkProcessorUtils.lambda$processStateMonitor$2(WorkProcessorUtils.java:241)
    at io.trino.operator.WorkProcessorUtils$ProcessWorkProcessor.process(WorkProcessorUtils.java:413)
    at io.trino.operator.WorkProcessorUtils.getNextState(WorkProcessorUtils.java:262)
    at io.trino.operator.WorkProcessorUtils.lambda$finishWhen$3(WorkProcessorUtils.java:256)
    at io.trino.operator.WorkProcessorUtils$ProcessWorkProcessor.process(WorkProcessorUtils.java:413)
    at io.trino.operator.WorkProcessorSourceOperatorAdapter.getOutput(WorkProcessorSourceOperatorAdapter.java:146)
    at io.trino.operator.Driver.processInternal(Driver.java:394)
    at io.trino.operator.Driver.lambda$process$8(Driver.java:297)
    at io.trino.operator.Driver.tryWithLock(Driver.java:689)
    at io.trino.operator.Driver.process(Driver.java:289)
    at io.trino.operator.Driver.processForDuration(Driver.java:260)
    at io.trino.execution.SqlTaskExecution$DriverSplitRunner.processFor(SqlTaskExecution.java:755)
    at io.trino.execution.executor.PrioritizedSplitRunner.process(PrioritizedSplitRunner.java:165)
    at io.trino.execution.executor.TaskExecutor$TaskRunner.run(TaskExecutor.java:523)
    at io.trino.$gen.Trino_406_dirty____20230209_045148_2.run(Unknown Source)
    at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136)
    at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635)
    at java.base/java.lang.Thread.run(Thread.java:833)
Caused by: java.lang.IllegalArgumentException: Multiple entries with same key: 2147483646=$row_id._file and 2147483646=_file
    at org.apache.iceberg.relocated.com.google.common.collect.ImmutableMap.conflictException(ImmutableMap.java:377)
    at org.apache.iceberg.relocated.com.google.common.collect.ImmutableMap.checkNoConflict(ImmutableMap.java:371)
    at org.apache.iceberg.relocated.com.google.common.collect.RegularImmutableMap.checkNoConflictInKeyBucket(RegularImmutableMap.java:241)
    at org.apache.iceberg.relocated.com.google.common.collect.RegularImmutableMap.fromEntryArrayCheckingBucketOverflow(RegularImmutableMap.java:132)
    at org.apache.iceberg.relocated.com.google.common.collect.RegularImmutableMap.fromEntryArray(RegularImmutableMap.java:94)
    at org.apache.iceberg.relocated.com.google.common.collect.ImmutableMap$Builder.build(ImmutableMap.java:573)
    at org.apache.iceberg.relocated.com.google.common.collect.ImmutableMap$Builder.buildOrThrow(ImmutableMap.java:601)
    at org.apache.iceberg.relocated.com.google.common.collect.ImmutableMap$Builder.build(ImmutableMap.java:588)
    at org.apache.iceberg.types.IndexByName.byId(IndexByName.java:81)
    at org.apache.iceberg.types.TypeUtil.indexNameById(TypeUtil.java:160)
    at org.apache.iceberg.Schema.lazyIdToName(Schema.java:183)
    at org.apache.iceberg.Schema.<init>(Schema.java:112)
    at org.apache.iceberg.Schema.<init>(Schema.java:91)
    at org.apache.iceberg.Schema.<init>(Schema.java:83)
    at org.apache.iceberg.Schema.<init>(Schema.java:79)
    at io.trino.plugin.iceberg.IcebergUtil.schemaFromHandles(IcebergUtil.java:250)
    at io.trino.plugin.iceberg.delete.EqualityDeleteFilter.createPredicate(EqualityDeleteFilter.java:49)
    at io.trino.plugin.iceberg.IcebergPageSourceProvider.lambda$createPageSource$7(IcebergPageSourceProvider.java:332)
    at java.base/java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:197)
    at java.base/java.util.ArrayList$ArrayListSpliterator.forEachRemaining(ArrayList.java:1625)
    at java.base/java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:509)
    at java.base/java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:499)
    at java.base/java.util.stream.ReduceOps$ReduceOp.evaluateSequential(ReduceOps.java:921)
    at java.base/java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)
    at java.base/java.util.stream.ReferencePipeline.reduce(ReferencePipeline.java:662)
    at io.trino.plugin.iceberg.IcebergPageSourceProvider.lambda$createPageSource$8(IcebergPageSourceProvider.java:333)
    at com.google.common.base.Suppliers$NonSerializableMemoizingSupplier.get(Suppliers.java:183)
    at io.trino.plugin.iceberg.IcebergPageSource.getNextPage(IcebergPageSource.java:125)
    ... 38 more
fritzb commented 1 year ago

@findepi looks like the hash collide on metadata $row_id.file and _file 2147483646=$row_id._file and 2147483646=_file

fritzb commented 1 year ago

Here are more observations:

  1. insert 1 row
  2. UPSERT using flink writer (set equality)
  3. UPDATE using trino, this will fail with Multiple entries with same key: 2147483646=$row_id._file and 2147483646=_file
  4. alter table metrics.map_making_metrics execute optimize;

After step 4, I can execute UPDATE.

So the workaround is alter table metrics.map_making_metrics execute optimize;

Heltman commented 1 year ago

@fritzb Actually, this is a different problem with #14836 . I fix it in #16216 , please cc: @jackye1995

fritzb commented 1 year ago

@Heltman @jackye1995

I tried the patch based on nested column fix, and it doesn't seem to work. Could you verify my patch ?

...
+            if (column.isUpdateRowIdColumn() || column.isMergeRowIdColumn()) {
+                field = NestedField.optional(column.getId(), column.getName(), toIcebergType(BOOLEAN, column.getColumnIdentity()));
+            }
+            else {
+                field = NestedField.optional(column.getId(), column.getName(), toIcebergType(column.getType(), column.getColumnIdentity()));
+            }
+            icebergColumns.add(field);
+        }

trino> update metrics.map_making_metrics set tags=null;

Query 20230223_042453_00013_t7pny, FAILED, 6 nodes
Splits: 1,577 total, 0 done (0.00%)
1.62 [1 rows, 13.8KB] [0 rows/s, 8.49KB/s]

Query 20230223_042453_00013_t7pny failed: Multiple entries with same key: 2147483646=$row_id._file and 2147483646=_file
Heltman commented 1 year ago

@fritzb please give full stack log

fritzb commented 1 year ago

@Heltman 

trino> update metrics.map_making_metrics set tags=null;

Query 20230223_174330_02380_t7pny, FAILED, 6 nodes
http://trino.staging.deepmap.ai/ui/query.html?20230223_174330_02380_t7pny
Splits: 1,177 total, 0 done (0.00%)
CPU Time: 0.0s total,     0 rows/s,     0B/s, 80% active
Per Node: 0.0 parallelism,     0 rows/s,     0B/s
Parallelism: 0.0
Peak Memory: 7.26MB
1.21 [0 rows, 0B] [0 rows/s, 0B/s]

Query 20230223_174330_02380_t7pny failed: Multiple entries with same key: 2147483646=$row_id._file and 2147483646=_file
io.trino.spi.TrinoException: Multiple entries with same key: 2147483646=$row_id._file and 2147483646=_file
    at io.trino.plugin.iceberg.IcebergPageSource.getNextPage(IcebergPageSource.java:142)
    at io.trino.operator.ScanFilterAndProjectOperator$ConnectorPageSourceToPages.process(ScanFilterAndProjectOperator.java:387)
    at io.trino.operator.WorkProcessorUtils$ProcessWorkProcessor.process(WorkProcessorUtils.java:413)
    at io.trino.operator.WorkProcessorUtils.getNextState(WorkProcessorUtils.java:262)
    at io.trino.operator.WorkProcessorUtils$YieldingProcess.process(WorkProcessorUtils.java:182)
    at io.trino.operator.WorkProcessorUtils$ProcessWorkProcessor.process(WorkProcessorUtils.java:413)
    at io.trino.operator.WorkProcessorUtils$3.process(WorkProcessorUtils.java:347)
    at io.trino.operator.WorkProcessorUtils$ProcessWorkProcessor.process(WorkProcessorUtils.java:413)
    at io.trino.operator.WorkProcessorUtils$3.process(WorkProcessorUtils.java:347)
    at io.trino.operator.WorkProcessorUtils$ProcessWorkProcessor.process(WorkProcessorUtils.java:413)
    at io.trino.operator.WorkProcessorUtils$3.process(WorkProcessorUtils.java:347)
    at io.trino.operator.WorkProcessorUtils$ProcessWorkProcessor.process(WorkProcessorUtils.java:413)
    at io.trino.operator.WorkProcessorUtils.getNextState(WorkProcessorUtils.java:262)
    at io.trino.operator.WorkProcessorUtils$BlockingProcess.process(WorkProcessorUtils.java:208)
    at io.trino.operator.WorkProcessorUtils$ProcessWorkProcessor.process(WorkProcessorUtils.java:413)
    at io.trino.operator.WorkProcessorUtils.lambda$flatten$6(WorkProcessorUtils.java:318)
    at io.trino.operator.WorkProcessorUtils$3.process(WorkProcessorUtils.java:360)
    at io.trino.operator.WorkProcessorUtils$ProcessWorkProcessor.process(WorkProcessorUtils.java:413)
    at io.trino.operator.WorkProcessorUtils$3.process(WorkProcessorUtils.java:347)
    at io.trino.operator.WorkProcessorUtils$ProcessWorkProcessor.process(WorkProcessorUtils.java:413)
    at io.trino.operator.WorkProcessorUtils.getNextState(WorkProcessorUtils.java:262)
    at io.trino.operator.WorkProcessorUtils.lambda$processStateMonitor$2(WorkProcessorUtils.java:241)
    at io.trino.operator.WorkProcessorUtils$ProcessWorkProcessor.process(WorkProcessorUtils.java:413)
    at io.trino.operator.WorkProcessorUtils.getNextState(WorkProcessorUtils.java:262)
    at io.trino.operator.WorkProcessorUtils.lambda$finishWhen$3(WorkProcessorUtils.java:256)
    at io.trino.operator.WorkProcessorUtils$ProcessWorkProcessor.process(WorkProcessorUtils.java:413)
    at io.trino.operator.WorkProcessorSourceOperatorAdapter.getOutput(WorkProcessorSourceOperatorAdapter.java:146)
    at io.trino.operator.Driver.processInternal(Driver.java:394)
    at io.trino.operator.Driver.lambda$process$8(Driver.java:297)
    at io.trino.operator.Driver.tryWithLock(Driver.java:689)
    at io.trino.operator.Driver.process(Driver.java:289)
    at io.trino.operator.Driver.processForDuration(Driver.java:260)
    at io.trino.execution.SqlTaskExecution$DriverSplitRunner.processFor(SqlTaskExecution.java:755)
    at io.trino.execution.executor.PrioritizedSplitRunner.process(PrioritizedSplitRunner.java:165)
    at io.trino.execution.executor.TaskExecutor$TaskRunner.run(TaskExecutor.java:523)
    at io.trino.$gen.Trino_406_dirty____20230223_042247_2.run(Unknown Source)
    at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136)
    at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635)
    at java.base/java.lang.Thread.run(Thread.java:833)
Caused by: java.lang.IllegalArgumentException: Multiple entries with same key: 2147483646=$row_id._file and 2147483646=_file
    at org.apache.iceberg.relocated.com.google.common.collect.ImmutableMap.conflictException(ImmutableMap.java:377)
    at org.apache.iceberg.relocated.com.google.common.collect.ImmutableMap.checkNoConflict(ImmutableMap.java:371)
    at org.apache.iceberg.relocated.com.google.common.collect.RegularImmutableMap.checkNoConflictInKeyBucket(RegularImmutableMap.java:241)
    at org.apache.iceberg.relocated.com.google.common.collect.RegularImmutableMap.fromEntryArrayCheckingBucketOverflow(RegularImmutableMap.java:132)
    at org.apache.iceberg.relocated.com.google.common.collect.RegularImmutableMap.fromEntryArray(RegularImmutableMap.java:94)
    at org.apache.iceberg.relocated.com.google.common.collect.ImmutableMap$Builder.build(ImmutableMap.java:573)
    at org.apache.iceberg.relocated.com.google.common.collect.ImmutableMap$Builder.buildOrThrow(ImmutableMap.java:601)
    at org.apache.iceberg.relocated.com.google.common.collect.ImmutableMap$Builder.build(ImmutableMap.java:588)
    at org.apache.iceberg.types.IndexByName.byId(IndexByName.java:81)
    at org.apache.iceberg.types.TypeUtil.indexNameById(TypeUtil.java:160)
    at org.apache.iceberg.Schema.lazyIdToName(Schema.java:183)
    at org.apache.iceberg.Schema.<init>(Schema.java:112)
    at org.apache.iceberg.Schema.<init>(Schema.java:91)
    at org.apache.iceberg.Schema.<init>(Schema.java:83)
    at org.apache.iceberg.Schema.<init>(Schema.java:79)
    at io.trino.plugin.iceberg.IcebergUtil.schemaFromHandles(IcebergUtil.java:250)
    at io.trino.plugin.iceberg.delete.EqualityDeleteFilter.createPredicate(EqualityDeleteFilter.java:49)
    at io.trino.plugin.iceberg.IcebergPageSourceProvider.lambda$createPageSource$7(IcebergPageSourceProvider.java:332)
    at java.base/java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:197)
    at java.base/java.util.ArrayList$ArrayListSpliterator.forEachRemaining(ArrayList.java:1625)
    at java.base/java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:509)
    at java.base/java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:499)
    at java.base/java.util.stream.ReduceOps$ReduceOp.evaluateSequential(ReduceOps.java:921)
    at java.base/java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)
    at java.base/java.util.stream.ReferencePipeline.reduce(ReferencePipeline.java:662)
    at io.trino.plugin.iceberg.IcebergPageSourceProvider.lambda$createPageSource$8(IcebergPageSourceProvider.java:333)
    at com.google.common.base.Suppliers$NonSerializableMemoizingSupplier.get(Suppliers.java:183)
    at io.trino.plugin.iceberg.IcebergPageSource.getNextPage(IcebergPageSource.java:125)
    ... 38 more
Heltman commented 1 year ago

@fritzb Can you debug test TestIcebergV2.testUpdateV2tableWithEqualityDelete? I add this for test this problem. When you breakpoint in field = NestedField.optional(column.getId(), column.getName(), toIcebergType(BOOLEAN, column.getColumnIdentity()));, you will see what the problem is.

tips: you need start docker server before you run test.

image

fritzb commented 1 year ago

Is there a wiki on how to run Trino in debugging mode (or through Docker)? Sorry, my experience with Trino was limited to patching and rebuilding the Docker image.

Heltman commented 1 year ago

@fritzb

  1. run install in idea or Simply run the following command from the project root directory

    ./mvnw clean install -DskipTests

  2. make sure docker server is started

    service docker status

  3. idea code run test