search

trinodb / trino

Official repository of Trino, the distributed SQL query engine for big data, formerly known as PrestoSQL (https://trino.io)
https://trino.io
Apache License 2.0
10.53k stars 3.03k forks source link

Enable Sigv4 Auth Provider for Cassandra #19495

Open kassett opened 1 year ago

kassett commented 1 year ago

AWS Keyspaces is a derivative of Cassandra, and should theoretically be supported by the Trino connector. However, it is does not support basic authentication, instead requiring Sigv4 authentication (https://github.com/aws/aws-sigv4-auth-cassandra-java-driver-plugin). Could we add support for AWS Keyspaces by integrating this plugin and allowing the configuration of IAM roles?

electrum commented 1 year ago

This seems reasonable. The Elasticsearch connector has AWS authentication support and thus is probably a good example to look at.

kassett commented 1 year ago

I will finish the PR by EOD. @electrum Any chance you can make me a collaborator so I can assign the issue to myself?

ebyhr commented 1 year ago

AWS doesn't offer the dockerized image of Keyspaces, right? Ideally, we want to have a testing environment.

kassett commented 1 year ago

There is no dockerized image, but support for this authprovider is plug and play. Perhaps we could just setup testing for the provider itself? Glue also doesn't have a docker image, for instance.

ebyhr commented 1 year ago

We run tests with the actual Glue instance. We could adapt the same approach for AWS Keyspaces as well, but someone need to pay 💰 to AWS.

kassett commented 1 year ago

I'll read into it -- I guess we could do that with Keyspaces too.