search

trinodb / trino

Official repository of Trino, the distributed SQL query engine for big data, formerly known as PrestoSQL (https://trino.io)
https://trino.io
Apache License 2.0
10.25k stars 2.95k forks source link

When we upgrade trino version we got an error version showed from monitor ui #20051

Closed ImTangYun closed 3 weeks ago

ImTangYun commented 9 months ago

Recently, we upgrade our trino version from 363 to 433, we found that the version showed from monitor ui is still 363: image which may be expected as: image

How we merge our code with trino version 433? 1.git checkout 368 2.git checkout -b our_368 3.add some commit to meet our needs 4.git checkout 433 5.git checkout -b our_433 6.git log our_368 and found the oldest commit id of our commit(for example：1053684f388ea68e8e9fc618579867201a8e032b) 7.git rebase --onto our_433 1053684f388ea68e8e9fc618579867201a8e032b 8.fix some conflicts and git rebase --continue 9.Then our_433 is what we compile and deploy

ImTangYun commented 9 months ago

We fixed This problem in pr:https://github.com/trinodb/trino/pull/20050

electrum commented 9 months ago

The reported Trino version is the same version shown when running git describe. It is based on Git tags, so you need to fetch tags to have the version shown correctly: git fetch upstream --tags

(replace upstream with the git remote name for the upstream Trino repository)

electrum commented 9 months ago

You can run git tag and verify that 433 is in the list of tags. Then run git describe and make sure that it shows the version that you expect.

ImTangYun commented 9 months ago

You can run git tag and verify that 433 is in the list of tags. Then run git describe and make sure that it shows the version that you expect.

Ok Thanks!