search

trinodb / trino

Official repository of Trino, the distributed SQL query engine for big data, formerly known as PrestoSQL (https://trino.io)
https://trino.io
Apache License 2.0
10.18k stars 2.93k forks source link

Missing Alluxio JMX metrics on coordinator #20794

Open jkylling opened 6 months ago

jkylling commented 6 months ago

Some of the JMX metrics which are enabled by https://github.com/trinodb/trino/blob/baa44358532b06893d60191c5be480a61ecc39b5/lib/trino-filesystem-cache-alluxio/src/main/java/io/trino/filesystem/alluxio/AlluxioFileSystemCacheModule.java#L61 are not propagated from the workers to the coordinator, while others are.

The metrics which are not propagated from the workers can still be exported directly from the workers with JMX export, but it's confusing that it's not available on the coordinator and through the JMX connector. In particular, Client.CacheHitRate is missing, which is useful to have when testing file system caching.

Alluxio also registers some generic JVM metrics which we ideally should not register.

danielcrisap commented 1 month ago

I'm using the JMX catalog but can't get the Client.CacheHitRate through it.

YuriSmychkovich commented 1 month ago

The Client.CacheHitRate metrics is not available in JMX export on workers.