search

trinodb / trino

Official repository of Trino, the distributed SQL query engine for big data, formerly known as PrestoSQL (https://trino.io)
https://trino.io
Apache License 2.0
10.26k stars 2.95k forks source link

Add support for comment on view #2241

Closed OmerJog closed 3 years ago

OmerJog commented 4 years ago

Many DBs support: comment on view some_view is 'Some View'; Example: https://stackoverflow.com/questions/4457656/create-view-in-postgres-sql-with-comments

can we have such support on presto?

ebyhr commented 4 years ago

can we have such support on presto?

Yes, I created the prototype before. Let me submit the PR.

OmerJog commented 4 years ago

thx. looking forward to it. Will it be in the next release?

ebyhr commented 4 years ago

Hmm, I think we can't merge it in the next version because our release cycle is fast. I would invite you to join community Slack https://prestosql.io/slack.html. It has #releases channel.

OmerJog commented 4 years ago

@ebyhr great. I hope this feature will be available soon

ebyhr commented 4 years ago

@OmerJog By the way, could you tell me the view type you want to add a comment, remote view (e.g. view in PostgreSQL) or Presto view? COMMENT ON VIEW in Presto will update comments for Presto view.

OmerJog commented 4 years ago

@ebyhr that's exactly what I want. Comments for native prestos views.

hylas-dev commented 3 years ago

Bump for this. Looks like comments can be put on views based on issue #2557 but "COMMENT ON VIEW" still has not been implemented.

ebyhr commented 3 years ago

Let us handle in #8349