search

trinodb / trino

Official repository of Trino, the distributed SQL query engine for big data, formerly known as PrestoSQL (https://trino.io)
https://trino.io
Apache License 2.0
10.14k stars 2.92k forks source link

[Pinot] Trino keeps query broker on gracefull shutdown #22523

Open Airliquide76 opened 2 months ago

Airliquide76 commented 2 months ago

I’m trying to restart a broker service on pinot side to grab a new timeout configuration.

I’ve 3 of them and continuously flowing query :innocence: 2/3 qps.

Disabling them make my query crashing on trino with a (Unexpected response status: 404 for request to url controlerUrl/debug/routingTable ) :déçu: Any advice of how to do this without any down time ? Still on an old pinot version prior to 1.0.

The best way to do this without error is : Remove broker tag / disable / restart / enable / addTag

Is there a way trino can avoid quering a broker going down ?

elonazoulay commented 2 months ago

I will check the code to make sure the brokerlist is refreshed. That should help to avoid this issue.