trinodb / trino

Official repository of Trino, the distributed SQL query engine for big data, formerly known as PrestoSQL (https://trino.io)
https://trino.io
Apache License 2.0
10.49k stars 3.02k forks source link

Cleanup UnnestNode filter removal #24108

Closed kasiafi closed 1 week ago

kasiafi commented 1 week ago

Related change: https://github.com/trinodb/trino/pull/20994/commits/bdbdc8f8ddb21c9e06a89f6e6666267d0e409f1b

Includes:

By removing filter from UnnestNode, we lost distinction between Unnest being in the context of a join or standalone. Given the way Unnest is planned, it is not incorrect. However, this information sometimes cannot be restored in plan printers.

No docs or release notes needed.

kasiafi commented 1 week ago

@lukasz-stec I added a test in TestLogicalPlanner, similar to the one you suggested.

kasiafi commented 1 week ago

@losipiuk ac