search

trinodb / trino

Official repository of Trino, the distributed SQL query engine for big data, formerly known as PrestoSQL (https://trino.io)
https://trino.io
Apache License 2.0
10.49k stars 3.02k forks source link

Enhance DevelopmentPluginsProvider to handle plugin directories #24128

Closed xkrogen closed 1 week ago

xkrogen commented 1 week ago

Description

This is an alternative approach to solve the same use case described in #23100.

This PR makes it possible to use the local DevelopmentServer with plugin directories, which have the same setup as a typical production plugin directory. This makes it easier to test the same setup you may have in a real production setup, but in your local development environment. This gives you the most apples-to-apples experience, and allows for easier integration of plugins developed on non-Maven builds. Some additional documentation is added to the README to describe the various ways to configure plugins in plugin.bundles.

Release notes

(X) This is not user-visible or is docs only, and no release notes are required. ( ) Release notes are required. Please propose a release note for me. ( ) Release notes are required, with the following suggested text:

xkrogen commented 1 week ago

cc @nineinchnick @mosabua this is an alternative approach to #23100, please take a look!

losipiuk commented 1 week ago

rebased and squashed

mosabua commented 1 week ago

Awesome .. thank you @xkrogen @losipiuk and @nineinchnick

xkrogen commented 1 week ago

Thanks for the reviews @mosabua @losipiuk and for the directional suggestion @nineinchnick !