Move DirectTrinoClient to a non-testing package - Githubissues

trinodb / trino

Official repository of Trino, the distributed SQL query engine for big data, formerly known as PrestoSQL (https://trino.io)

https://trino.io

Apache License 2.0

10.49k stars 3.02k forks source link

Move DirectTrinoClient to a non-testing package #24193

Closed ksobolew closed 12 hours ago

ksobolew commented 1 day ago

Description

This originted in testing code, but it is being repurposed as a general-purpose utility, so it should not be in a testing package.

The tests for this class are in the testing/trino-tests module in class io.trino.tests.TestLocalQueries, so they are not moved along with it.

Additional context and related issues

Release notes

(x) This is not user-visible or is docs only, and no release notes are required.

It's technically user-visible, but I don't think we're advertising this feature

( ) Release notes are required. Please propose a release note for me. ( ) Release notes are required, with the following suggested text:

## Section
* Fix some things. ({issue}`issuenumber`)

martint commented 8 hours ago

This doesn’t seem to have any uses other than in tests, so it should remain where it was. We don’t do “general purpose utilities” for out-of-tree projects to use.