search

trinodb / trino

Official repository of Trino, the distributed SQL query engine for big data, formerly known as PrestoSQL (https://trino.io)
https://trino.io
Apache License 2.0
10.49k stars 3.02k forks source link

Clarify Phoenix requirement #24207

Closed mosabua closed 1 day ago

mosabua commented 1 day ago

Description

For now we only know of the Phoenix connector being affected as a result of it loading Hadoop libraries. We do not add this for the object storage connectors since the old file system stuff with Hadoop dependencies is considered legacy. And we are not aware of other connectors with this problem.

Additional context and related issues

Follow up to https://github.com/trinodb/trino/pull/24203

Release notes

(x) This is not user-visible or is docs only, and no release notes are required.

mosabua commented 1 day ago

Fyi @hashhar @wendigo @ebyhr - since this is only for the Phoenix connector we did not want this in the overall JVM configs. If it is truly required for Trino itself, it should be automatically added .. maybe by the launcher like https://github.com/airlift/airlift/blob/df5d89bde1d09b09c4a386551ad03bccf0ff84b1/launcher/src/main/scripts/bin/launcher.py#L231

hashhar commented 15 hours ago

As of now we do ship the Docker image (and then tarball and RPM later) with this config added to the default jvm.config.

If we want to not have this in overall JVM config we need to remove that from docs + RPM/tarball and Docker image.

mosabua commented 3 hours ago

Yeah .. maybe we should discuss this in the maintainer call. Currently this is all inconsistent.