search

trinodb / trino

Official repository of Trino, the distributed SQL query engine for big data, formerly known as PrestoSQL (https://trino.io)
https://trino.io
Apache License 2.0
10.42k stars 3k forks source link

Refactor TestFileBasedSystemAccessControl to use Java objects instead of files #3952

Open haldes opened 4 years ago

haldes commented 4 years ago

@kokosing @findepi Opening this issue to track the below refactoring suggestion. https://github.com/prestosql/presto/pull/3766#discussion_r427119728

haldes commented 4 years ago

@kokosing @findepi

Please assign this issue to me.

dain commented 4 years ago

I think we will still need some stored files tests, so we can verify that we are not breaking backwards compatibility.

kokosing commented 4 years ago

I think we will still need some stored files tests, so we can verify that we are not breaking backwards compatibility.

That's correct. Especially we should test what is written in docs.

findepi commented 4 years ago

we should test what is written in docs.

That's actually pretty easy. We do this for resource groups' docs.

haldes commented 4 years ago

we should test what is written in docs.

That's actually pretty easy. We do this for resource groups' docs.

@findepi - Can you point me to the code location

findepi commented 4 years ago

@haldes see io.prestosql.plugin.resourcegroups.TestFileResourceGroupConfigurationManager#testDocsExample and io.prestosql.plugin.base.security.TestFileBasedSystemAccessControl#testDocsExample for examples