Open findepi opened 4 years ago
BadInstanceof, CompareToZero, InconsistentHashCode, ObjectToString are enabled in #4289
ImmutableEnumChecker, ImmutableAnnotationChecker, Immutable, ImmutableModification were enabled in #4470
I added OptionalEquality
to the list. It's apparently possible to make a mistake when refactoring the code, like here
https://github.com/prestosql/presto/blob/ece62ab29bc96a723669687e17bc2eef183a2d4d/presto-base-jdbc/src/main/java/io/prestosql/plugin/jdbc/JdbcTypeHandle.java#L130
The checks are defined here: https://github.com/prestosql/presto/blob/fcb91631a655f8af7c6aeb803861d1c738f67281/pom.xml#L1424
Here's how to run the checks: https://github.com/prestosql/presto/blob/fcb91631a655f8af7c6aeb803861d1c738f67281/.github/workflows/ci.yml#L72-L73
-XepDisableAllChecks
)