search

trinodb / trino

Official repository of Trino, the distributed SQL query engine for big data, formerly known as PrestoSQL (https://trino.io)
https://trino.io
Apache License 2.0
9.86k stars 2.85k forks source link

Improve Calcite shading #5604

Open findepi opened 3 years ago

findepi commented 3 years ago 
$ jar tf .m2/repository/com/linkedin/calcite/calcite-core/1.21.0.140/calcite-core-1.21.0.140-shaded.jar | cut -d/ -f -3 | sort | uniq -c | sort -rn
   4746 com/linkedin/coral
   3772 org/apache/calcite
    504 org/apache/commons
    463 org/codehaus/janino
    238 org/yaml/snakeyaml
    205 com/yahoo/sketches
    187 com/jayway/jsonpath
     32 org/codehaus/commons
     15 com/yahoo/memory
...

Seems that, despite the "shaded" classifier", the dependencies are not fully relocated.

This doesn't cause a problem today, but will cause a problem as soon as we want to use anything depending (directly or transitively) on these not-properly-shaded libraries.

findepi commented 3 years ago

cc @laurachenyu @phd3

findepi commented 3 years ago

I posted a proposed fix to the project -- https://github.com/linkedin/linkedin-calcite/pull/29

findepi commented 3 years ago

@phd3 @laurachenyu can you possibly connect the https://github.com/linkedin/linkedin-calcite/pull/29 PR with the right person to review that?

hashhar commented 4 months ago

We now have our own shaded Coral, is this still relevant?